Add support for disabling broken profiles

This commit is contained in:
2026-04-12 19:23:34 +02:00
parent ad673f29ad
commit 9b329e513a
5 changed files with 566 additions and 59 deletions

View File

@@ -31,6 +31,7 @@ let updatesStreamHealthy = false;
let updatesShouldResyncOnConnect = false;
const MAX_PROFILES = 5;
const DEFAULT_ACTIVE_PROFILES = Array.from({ length: MAX_PROFILES }, (_unused, index) => index + 1);
const PROFILE_NAMES = {
1: 'Profil 1',
2: 'Profil 2',
@@ -38,11 +39,42 @@ const PROFILE_NAMES = {
4: 'Profil 4',
5: 'Profil 5'
};
let activeProfileNumbers = [...DEFAULT_ACTIVE_PROFILES];
function isValidProfileNumber(value) {
return Number.isInteger(value) && value >= 1 && value <= MAX_PROFILES;
}
function normalizeActiveProfileNumbers(values) {
if (!Array.isArray(values)) {
return [...DEFAULT_ACTIVE_PROFILES];
}
const seen = new Set();
const normalized = values
.map((value) => parseInt(value, 10))
.filter((value) => isValidProfileNumber(value) && !seen.has(value) && seen.add(value))
.sort((a, b) => a - b);
return normalized.length ? normalized : [...DEFAULT_ACTIVE_PROFILES];
}
function getActiveProfileNumbers() {
return activeProfileNumbers.length ? [...activeProfileNumbers] : [...DEFAULT_ACTIVE_PROFILES];
}
function isSelectableProfileNumber(value) {
return isValidProfileNumber(value) && getActiveProfileNumbers().includes(value);
}
function getActiveTargetCountLimit() {
return Math.max(1, getActiveProfileNumbers().length);
}
function getTargetCountErrorMessage() {
return `Die Anzahl der benötigten Profile muss zwischen 1 und ${getActiveTargetCountLimit()} liegen.`;
}
function redirectToLogin() {
try {
const redirect = encodeURIComponent(window.location.href);
@@ -2142,11 +2174,12 @@ function normalizeRequiredProfiles(post) {
}
const parsedTarget = parseInt(post.target_count, 10);
const activeProfiles = getActiveProfileNumbers();
const count = Number.isNaN(parsedTarget)
? 1
: Math.min(MAX_PROFILES, Math.max(1, parsedTarget));
: Math.min(activeProfiles.length, Math.max(1, parsedTarget));
return Array.from({ length: count }, (_, index) => index + 1);
return activeProfiles.slice(0, count);
}
function getTabButtons() {
@@ -3510,7 +3543,7 @@ function applyAutoRefreshSettings() {
autoRefreshTimer = null;
}
if (!isValidProfileNumber(currentProfile)) {
if (!isSelectableProfileNumber(currentProfile)) {
return;
}
@@ -3534,7 +3567,7 @@ function applyAutoRefreshSettings() {
if (document.hidden) {
return;
}
if (!isValidProfileNumber(currentProfile)) {
if (!isSelectableProfileNumber(currentProfile)) {
return;
}
fetchPosts({ showLoader: false });
@@ -3782,6 +3815,90 @@ function applyScreenshotModalSize() {
});
}
function renderProfileSelectorOptions() {
if (!profileSelectElement) {
return;
}
const activeProfiles = getActiveProfileNumbers();
profileSelectElement.innerHTML = `
<option value="">-- Profil wählen --</option>
${activeProfiles.map((profileNumber) => `
<option value="${profileNumber}">${getProfileName(profileNumber)}</option>
`).join('')}
`;
if (isSelectableProfileNumber(currentProfile)) {
profileSelectElement.value = String(currentProfile);
}
}
function renderManualTargetOptions(selectedValue = 1) {
if (!manualPostTargetSelect) {
return;
}
const maxCount = getActiveTargetCountLimit();
const normalizedSelected = Math.max(1, Math.min(maxCount, parseInt(selectedValue, 10) || 1));
manualPostTargetSelect.innerHTML = Array.from({ length: maxCount }, (_unused, index) => {
const value = index + 1;
return `<option value="${value}">${value}</option>`;
}).join('');
manualPostTargetSelect.value = String(normalizedSelected);
}
function clearSelectedProfile(message = 'Bitte zuerst ein Profil auswählen.') {
if (profileSelectElement) {
profileSelectElement.value = '';
}
currentProfile = null;
try {
localStorage.removeItem('profileNumber');
} catch (error) {
console.warn('Konnte gespeichertes Profil nicht entfernen:', error);
}
pendingOpenCooldownMap = loadPendingOpenCooldownMap(null);
renderPosts();
applyAutoRefreshSettings();
showError(message);
}
function applyProfileSettings(settings, { rerender = true, refreshPosts = false } = {}) {
const nextActiveProfiles = normalizeActiveProfileNumbers(settings && settings.active_profiles);
activeProfileNumbers = nextActiveProfiles;
renderProfileSelectorOptions();
renderManualTargetOptions(manualPostTargetSelect ? manualPostTargetSelect.value : 1);
if (currentProfile !== null && !isSelectableProfileNumber(currentProfile)) {
clearSelectedProfile('Das gespeicherte Profil ist deaktiviert. Bitte wähle ein aktives Profil.');
} else if (profileSelectElement && isSelectableProfileNumber(currentProfile)) {
profileSelectElement.value = String(currentProfile);
}
if (rerender && currentProfile !== null) {
renderPosts();
}
if (refreshPosts) {
fetchPosts({ showLoader: false });
}
}
async function loadProfileSettings() {
try {
const response = await apiFetch(`${API_URL}/profile-settings`);
if (!response.ok) {
return null;
}
const data = await response.json();
applyProfileSettings(data, { rerender: false });
return data;
} catch (error) {
console.warn('Profil-Einstellungen konnten nicht geladen werden:', error);
return null;
}
}
async function fetchProfileState() {
try {
const response = await apiFetch(`${API_URL}/profile-state`);
@@ -3815,16 +3932,16 @@ async function pushProfileState(profileNumber) {
}
function ensureProfileSelected() {
if (isValidProfileNumber(currentProfile)) {
if (isSelectableProfileNumber(currentProfile)) {
hideError();
return true;
}
showError('Bitte zuerst ein Profil auswählen.');
showError('Bitte zuerst ein aktives Profil auswählen.');
return false;
}
function applyProfileNumber(profileNumber, { fromBackend = false } = {}) {
if (!isValidProfileNumber(profileNumber)) {
if (!isSelectableProfileNumber(profileNumber)) {
return;
}
@@ -3863,20 +3980,16 @@ function applyProfileNumber(profileNumber, { fromBackend = false } = {}) {
// Load profile from localStorage
function loadProfile() {
fetchProfileState().then((backendProfile) => {
if (isValidProfileNumber(backendProfile)) {
if (isSelectableProfileNumber(backendProfile)) {
applyProfileNumber(backendProfile, { fromBackend: true });
} else {
const saved = localStorage.getItem('profileNumber');
const parsed = saved ? parseInt(saved, 10) : NaN;
if (isValidProfileNumber(parsed)) {
if (isSelectableProfileNumber(parsed)) {
applyProfileNumber(parsed, { fromBackend: true });
return;
}
if (profileSelectElement) {
profileSelectElement.value = '';
}
currentProfile = null;
showError('Bitte zuerst ein Profil auswählen.');
clearSelectedProfile('Bitte zuerst ein aktives Profil auswählen.');
}
});
}
@@ -3893,8 +4006,12 @@ function startProfilePolling() {
profilePollTimer = setInterval(async () => {
const backendProfile = await fetchProfileState();
if (backendProfile && backendProfile !== currentProfile) {
if (isSelectableProfileNumber(backendProfile) && backendProfile !== currentProfile) {
applyProfileNumber(backendProfile, { fromBackend: true });
return;
}
if (backendProfile === null && currentProfile !== null && !isSelectableProfileNumber(currentProfile)) {
clearSelectedProfile('Das gespeicherte Profil ist deaktiviert. Bitte wähle ein aktives Profil.');
}
}, 5000);
}
@@ -3903,8 +4020,8 @@ function startProfilePolling() {
if (profileSelectElement) {
profileSelectElement.addEventListener('change', (e) => {
const parsed = parseInt(e.target.value, 10);
if (!isValidProfileNumber(parsed)) {
showError('Bitte zuerst ein Profil auswählen.');
if (!isSelectableProfileNumber(parsed)) {
showError('Bitte zuerst ein aktives Profil auswählen.');
return;
}
saveProfile(parsed);
@@ -4984,7 +5101,7 @@ function createPostCard(post, status, meta = {}) {
<div class="post-target">
<span>Benötigte Profile:</span>
<select class="control-select post-target__select" data-post-id="${post.id}">
${Array.from({ length: MAX_PROFILES }, (_, index) => index + 1)
${Array.from({ length: getActiveTargetCountLimit() }, (_, index) => index + 1)
.map((value) => `
<option value="${value}" ${value === status.targetCount ? 'selected' : ''}>${value}</option>
`).join('')}
@@ -5180,7 +5297,7 @@ function populateManualPostForm(post) {
if (manualPostTargetSelect) {
const targetValue = parseInt(post.target_count, 10);
manualPostTargetSelect.value = Number.isNaN(targetValue) ? '1' : String(targetValue);
renderManualTargetOptions(Number.isNaN(targetValue) ? 1 : targetValue);
}
if (manualPostCreatorInput) {
@@ -5206,7 +5323,7 @@ function resetManualPostForm({ keepMessages = false } = {}) {
manualPostForm.reset();
if (manualPostTargetSelect) {
manualPostTargetSelect.value = '1';
renderManualTargetOptions(1);
}
if (manualPostUrlInput) {
@@ -5271,7 +5388,7 @@ async function updateTargetInline(postId, value, selectElement) {
return;
}
if (Number.isNaN(value) || value < 1 || value > MAX_PROFILES) {
if (Number.isNaN(value) || value < 1 || value > getActiveTargetCountLimit()) {
renderPosts();
return;
}
@@ -5327,8 +5444,8 @@ async function handleManualPostSubmit(event) {
const targetValue = manualPostTargetSelect ? manualPostTargetSelect.value : '1';
const parsedTarget = parseInt(targetValue, 10);
if (Number.isNaN(parsedTarget) || parsedTarget < 1 || parsedTarget > MAX_PROFILES) {
displayManualPostMessage('Die Anzahl der benötigten Profile muss zwischen 1 und 5 liegen.', 'error');
if (Number.isNaN(parsedTarget) || parsedTarget < 1 || parsedTarget > getActiveTargetCountLimit()) {
displayManualPostMessage(getTargetCountErrorMessage(), 'error');
return;
}
@@ -5603,6 +5720,11 @@ window.addEventListener('app:view-change', (event) => {
updatePostsScrollTopButtonVisibility();
});
window.addEventListener('profile-settings-updated', (event) => {
const settings = event && event.detail ? event.detail : null;
applyProfileSettings(settings || null, { refreshPosts: true });
});
document.addEventListener('visibilitychange', () => {
if (document.visibilityState === 'visible' && pendingAutoOpenEnabled) {
if (pendingAutoOpenTimerId) {
@@ -5629,6 +5751,9 @@ async function bootstrapApp() {
initializeTabFromUrl();
updateMergeControlsUI();
loadSortMode();
renderProfileSelectorOptions();
renderManualTargetOptions(1);
await loadProfileSettings();
resetManualPostForm();
loadProfile();
startProfilePolling();

View File

@@ -1102,6 +1102,16 @@
</section>
<!-- Profile Friends Section -->
<section class="settings-section">
<h2 class="section-title">🧩 Aktive Profile</h2>
<p class="section-description">
Deaktivierte Profile werden in der Bestätigungsreihenfolge übersprungen. Die maximale Anzahl benötigter Profile reduziert sich automatisch auf die Zahl der aktiven Profile.
</p>
<div id="profileActivationList" class="profile-activation-list"></div>
<p id="profileActivationSummary" class="form-help"></p>
</section>
<section class="settings-section">
<h2 class="section-title">👥 Freundesnamen pro Profil</h2>
<p class="section-description">

View File

@@ -95,6 +95,39 @@
line-height: 1.4;
}
.profile-activation-list {
display: grid;
grid-template-columns: repeat(auto-fit, minmax(220px, 1fr));
gap: 12px;
}
.profile-activation-item {
display: flex;
align-items: flex-start;
gap: 10px;
padding: 14px 16px;
border: 1px solid #e4e6eb;
border-radius: 10px;
background: #f8fafc;
}
.profile-activation-item__copy {
display: flex;
flex-direction: column;
gap: 4px;
}
.profile-activation-item__title {
font-size: 14px;
font-weight: 600;
color: #1c1e21;
}
.profile-activation-item__hint {
font-size: 12px;
color: #65676b;
}
.grid-weights {
display: grid;
grid-template-columns: repeat(auto-fit, minmax(220px, 1fr));

View File

@@ -52,10 +52,13 @@ const AI_AUTO_COMMENT_RATE_LIMIT_DEFAULTS = Object.freeze({
active_hours_start: '',
active_hours_end: ''
});
const MAX_PROFILES = 5;
const DEFAULT_ACTIVE_PROFILES = Array.from({ length: MAX_PROFILES }, (_unused, index) => index + 1);
let credentials = [];
let currentSettings = null;
let hiddenSettings = { auto_purge_enabled: true, retention_days: 90 };
let profileSettings = { active_profiles: [...DEFAULT_ACTIVE_PROFILES], max_target_count: MAX_PROFILES };
const SPORT_WEIGHT_FIELDS = [
{ key: 'scoreline', id: 'sportWeightScoreline' },
{ key: 'scoreEmoji', id: 'sportWeightScoreEmoji' },
@@ -1229,7 +1232,7 @@ async function testComment() {
try {
const data = JSON.parse(lastTest);
document.getElementById('testPostText').value = data.postText || '';
document.getElementById('testProfileNumber').value = data.profileNumber || '1';
renderTestProfileOptions(data.profileNumber || profileSettings.active_profiles[0] || 1);
} catch (e) {
console.error('Failed to load last test comment:', e);
}
@@ -1313,6 +1316,7 @@ async function saveAllSettings(event) {
const results = await Promise.all([
saveSettings(null, { silent: true }),
saveProfileSettings(null, { silent: true }),
saveHiddenSettings(null, { silent: true }),
saveModerationSettings(null, { silent: true }),
saveSimilaritySettings(null, { silent: true }),
@@ -1343,6 +1347,146 @@ async function saveAllSettings(event) {
}
}
function normalizeActiveProfileNumbers(values) {
if (!Array.isArray(values)) {
return [...DEFAULT_ACTIVE_PROFILES];
}
const seen = new Set();
const normalized = values
.map((value) => parseInt(value, 10))
.filter((value) => Number.isInteger(value) && value >= 1 && value <= MAX_PROFILES && !seen.has(value) && seen.add(value))
.sort((a, b) => a - b);
return normalized.length ? normalized : [...DEFAULT_ACTIVE_PROFILES];
}
function collectActiveProfilesFromInputs() {
return Array.from(document.querySelectorAll('.profile-activation-checkbox:checked'))
.map((input) => parseInt(input.value, 10))
.filter((value) => Number.isInteger(value) && value >= 1 && value <= MAX_PROFILES)
.sort((a, b) => a - b);
}
function renderTestProfileOptions(selectedValue = null) {
const select = document.getElementById('testProfileNumber');
if (!select) {
return;
}
const activeProfiles = normalizeActiveProfileNumbers(profileSettings.active_profiles);
const fallbackValue = activeProfiles[0] || 1;
const normalizedSelected = activeProfiles.includes(parseInt(selectedValue, 10))
? parseInt(selectedValue, 10)
: fallbackValue;
select.innerHTML = activeProfiles.map((profileNumber) => (
`<option value="${profileNumber}">Profil ${profileNumber}</option>`
)).join('');
select.value = String(normalizedSelected);
}
function updateProfileActivationSummary() {
const summary = document.getElementById('profileActivationSummary');
if (!summary) {
return;
}
const activeProfiles = collectActiveProfilesFromInputs();
summary.textContent = `Aktiv: ${activeProfiles.length} von ${MAX_PROFILES}. Max. benötigte Profile: ${Math.max(1, activeProfiles.length)}.`;
}
function renderProfileActivationList() {
const container = document.getElementById('profileActivationList');
if (!container) {
return;
}
const activeProfiles = normalizeActiveProfileNumbers(profileSettings.active_profiles);
container.innerHTML = DEFAULT_ACTIVE_PROFILES.map((profileNumber) => {
const checked = activeProfiles.includes(profileNumber);
return `
<label class="profile-activation-item">
<input
type="checkbox"
class="form-checkbox profile-activation-checkbox"
value="${profileNumber}"
${checked ? 'checked' : ''}
>
<span class="profile-activation-item__copy">
<span class="profile-activation-item__title">Profil ${profileNumber}</span>
<span class="profile-activation-item__hint">${checked ? 'Aktiv im Bestätigungsfluss' : 'Wird übersprungen'}</span>
</span>
</label>
`;
}).join('');
container.querySelectorAll('.profile-activation-checkbox').forEach((checkbox) => {
checkbox.addEventListener('change', (event) => {
const checkedProfiles = collectActiveProfilesFromInputs();
if (!checkedProfiles.length) {
event.target.checked = true;
showError('❌ Mindestens ein Profil muss aktiv bleiben');
return;
}
updateProfileActivationSummary();
renderTestProfileOptions(document.getElementById('testProfileNumber')?.value || checkedProfiles[0]);
});
});
updateProfileActivationSummary();
renderTestProfileOptions(document.getElementById('testProfileNumber')?.value || activeProfiles[0] || 1);
}
async function loadProfileSettings() {
const res = await apiFetch(`${API_URL}/profile-settings`);
if (!res.ok) throw new Error('Failed to load profile settings');
profileSettings = await res.json();
profileSettings.active_profiles = normalizeActiveProfileNumbers(profileSettings.active_profiles);
renderProfileActivationList();
}
async function saveProfileSettings(event, { silent = false } = {}) {
if (event && typeof event.preventDefault === 'function') {
event.preventDefault();
}
try {
const activeProfiles = collectActiveProfilesFromInputs();
if (!activeProfiles.length) {
throw new Error('Mindestens ein Profil muss aktiv bleiben');
}
const res = await apiFetch(`${API_URL}/profile-settings`, {
method: 'PUT',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ active_profiles: activeProfiles })
});
if (!res.ok) {
const err = await res.json().catch(() => null);
throw new Error((err && err.error) || 'Fehler beim Speichern');
}
profileSettings = await res.json();
profileSettings.active_profiles = normalizeActiveProfileNumbers(profileSettings.active_profiles);
renderProfileActivationList();
if (!silent) {
await loadProfileFriends();
}
window.dispatchEvent(new CustomEvent('profile-settings-updated', { detail: profileSettings }));
if (!silent) {
showSuccess('✅ Aktive Profile gespeichert');
}
return true;
} catch (err) {
if (!silent) {
showError('❌ ' + err.message);
}
return false;
}
}
// ============================================================================
// PROFILE FRIENDS
// ============================================================================
@@ -1353,10 +1497,11 @@ async function loadProfileFriends() {
const list = document.getElementById('profileFriendsList');
list.innerHTML = '';
for (let i = 1; i <= 5; i++) {
for (let i = 1; i <= MAX_PROFILES; i++) {
const res = await apiFetch(`${API_URL}/profile-friends/${i}`);
const data = await res.json();
profileFriends[i] = data.friend_names || '';
const isActive = normalizeActiveProfileNumbers(profileSettings.active_profiles).includes(i);
const div = document.createElement('div');
div.className = 'form-group';
@@ -1365,7 +1510,7 @@ async function loadProfileFriends() {
<input type="text" id="friends${i}" class="form-input"
placeholder="z.B. Anna, Max, Lisa"
value="${escapeHtml(profileFriends[i])}">
<p class="form-help">Kommagetrennte Liste von Freundesnamen für Profil ${i}</p>
<p class="form-help">Kommagetrennte Liste von Freundesnamen für Profil ${i}${isActive ? '' : ' (derzeit deaktiviert)'}</p>
`;
list.appendChild(div);
@@ -1406,7 +1551,7 @@ async function saveFriends(profileNumber, friendNames, { silent = false } = {})
async function saveAllFriends({ silent = false } = {}) {
let success = true;
for (let i = 1; i <= 5; i++) {
for (let i = 1; i <= MAX_PROFILES; i++) {
const input = document.getElementById(`friends${i}`);
if (!input) {
continue;
@@ -1533,12 +1678,19 @@ if (similarityForm) {
}
// Initialize
Promise.all([
loadCredentials(),
loadSettings(),
loadHiddenSettings(),
loadModerationSettings(),
loadSimilaritySettings(),
loadProfileFriends()
]).catch(err => showError(err.message));
(async () => {
try {
await Promise.all([
loadCredentials(),
loadSettings(),
loadProfileSettings(),
loadHiddenSettings(),
loadModerationSettings(),
loadSimilaritySettings()
]);
await loadProfileFriends();
} catch (err) {
showError(err.message);
}
})();
})();