From 5a7f28dff5552ff8e728a645ce1567827ad9a206 Mon Sep 17 00:00:00 2001
From: Meik <meik.drechsler@consulting4it.de>
Date: Thu, 2 Jul 2026 13:07:56 +0200
Subject: [PATCH] fix: support query routes for legacy endpoints

---
 F4SDM42WebApi/F4SDM42WebApiController.cs               | 10 +++++-----
 .../02-01-0060 PLSLWebServiceOperationType.dat         |  2 +-
 .../02-01-0070 PLSLWebServiceOperationType.dat         |  2 +-
 .../install/0002_WebServiceOperation/getpickup.dat     |  2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/F4SDM42WebApi/F4SDM42WebApiController.cs b/F4SDM42WebApi/F4SDM42WebApiController.cs
index 7d6cc77..b99ee61 100644
--- a/F4SDM42WebApi/F4SDM42WebApiController.cs
+++ b/F4SDM42WebApi/F4SDM42WebApiController.cs
@@ -94,15 +94,15 @@ namespace C4IT.F4SD
             return GetRequiredService<IJournalService>();
         }
 
-        [Route("getDirectLinkCreateTicket/{sid}/{assetname}"), HttpGet]
+        [Route("getDirectLinkCreateTicket/{sid?}/{assetname?}"), HttpGet]
         public async Task<F4SDHelperService.DirectLink> getDirectLinkCreateTicket(string sid = "", string assetname = "")
         {
             await Task.Delay(0);
             return await _f4stHelperService.getDirectLinkCreateTicket(sid, assetname)
                 ?? new F4SDHelperService.DirectLink();
         }
-        [Route("getDirectLinkF4SD/{eoid}/{type}"), HttpGet]
-        public async Task<string> getDirectLinkF4SD(Guid eoid, string type)
+        [Route("getDirectLinkF4SD/{eoid?}/{type?}"), HttpGet]
+        public async Task<string> getDirectLinkF4SD(Guid eoid, string type = "")
         {
             return await _f4stHelperService.getDirectLinkF4SD(eoid, type) ?? string.Empty;
         }
@@ -211,9 +211,9 @@ namespace C4IT.F4SD
             };
         }
         */
-        [Route("getPickup/{name}"), HttpGet]
+        [Route("getPickup/{name?}"), HttpGet]
         //[CacheOutput(UseETAG = true)]
-        public async Task<EntityEnumeration> getPickup(string name, EntityEnumerationVisibilityMode mode = EntityEnumerationVisibilityMode.None, Int32 group = -1)
+        public async Task<EntityEnumeration> getPickup(string name = "", EntityEnumerationVisibilityMode mode = EntityEnumerationVisibilityMode.None, Int32 group = -1)
         {
             await Task.Delay(0);
             EntityEnumeration enumerationTemp = GetEnumeration(name, mode);
diff --git a/PackageTemplate/install/0002_WebServiceOperation/02-01-0060 PLSLWebServiceOperationType.dat b/PackageTemplate/install/0002_WebServiceOperation/02-01-0060 PLSLWebServiceOperationType.dat
index a196c76..6fd6da7 100644
--- a/PackageTemplate/install/0002_WebServiceOperation/02-01-0060 PLSLWebServiceOperationType.dat	
+++ b/PackageTemplate/install/0002_WebServiceOperation/02-01-0060 PLSLWebServiceOperationType.dat	
@@ -139,7 +139,7 @@
 		<ID>b3193051-6fe6-cdd2-7d76-08da9bbec2b6</ID>
 		<RequestContract>{"UsedTypes":{"RequestContract":{"Descriptor":{"sid":{"Type":"StringType"},"assetname":{"Type":"StringType"}}}},"ContractDescriptor":{"ReferenceTo":null,"ReferenceFilter":null,"Required":false,"Obsolete":false,"MaxLength":0,"ResourceKey":null,"Documentation":null,"Title":null,"Paths":null,"Type":"RequestContract"}}</RequestContract>
 		<Name>getDirectLinkCreateTicket(sid, assetname)</Name>
-		<RouteTemplate>getDirectLinkCreateTicket/{sid}/{assetname}</RouteTemplate>
+		<RouteTemplate>getDirectLinkCreateTicket</RouteTemplate>
 		<Documentation />
 		<TypeID>7660e907-769c-e711-a182-f079595b3ec7</TypeID>
 		<Service>dcd66369-4933-ed11-1b9c-e3e293f5401c</Service>
diff --git a/PackageTemplate/install/0002_WebServiceOperation/02-01-0070 PLSLWebServiceOperationType.dat b/PackageTemplate/install/0002_WebServiceOperation/02-01-0070 PLSLWebServiceOperationType.dat
index 6a3ab48..6344807 100644
--- a/PackageTemplate/install/0002_WebServiceOperation/02-01-0070 PLSLWebServiceOperationType.dat	
+++ b/PackageTemplate/install/0002_WebServiceOperation/02-01-0070 PLSLWebServiceOperationType.dat	
@@ -139,7 +139,7 @@
 		<ID>04d0755f-27dd-c4ac-2785-08dac1666661</ID>
 		<RequestContract>{"UsedTypes":{"RequestContract":{"Descriptor":{"eoid":{"Type":"StringType"},"type":{"Type":"StringType"}}}},"ContractDescriptor":{"ReferenceTo":null,"ReferenceFilter":null,"Required":false,"Obsolete":false,"MaxLength":0,"ResourceKey":null,"Documentation":null,"Title":null,"Paths":null,"Type":"RequestContract"}}</RequestContract>
 		<Name>getDirectLinkF4SD(eoid, type)</Name>
-		<RouteTemplate>getDirectLinkF4SD/{eoid}/{type}</RouteTemplate>
+		<RouteTemplate>getDirectLinkF4SD</RouteTemplate>
 		<Documentation />
 		<TypeID>7660e907-769c-e711-a182-f079595b3ec7</TypeID>
 		<Service>dcd66369-4933-ed11-1b9c-e3e293f5401c</Service>
diff --git a/PackageTemplate/install/0002_WebServiceOperation/getpickup.dat b/PackageTemplate/install/0002_WebServiceOperation/getpickup.dat
index 3bf6fbd..ae00c93 100644
--- a/PackageTemplate/install/0002_WebServiceOperation/getpickup.dat
+++ b/PackageTemplate/install/0002_WebServiceOperation/getpickup.dat
@@ -139,7 +139,7 @@
 		<ID>ef14b892-628c-c1c1-801f-08db99ad32e9</ID>
 		<RequestContract>{"UsedTypes":{"RequestContract":{"Descriptor":{"name":{"Type":"StringType"},"mode":{"Type":"StringType"},"group":{"Type":"StringType"}}}},"ContractDescriptor":{"ReferenceTo":null,"ReferenceFilter":null,"Required":false,"Obsolete":false,"MaxLength":0,"ResourceKey":null,"Documentation":null,"Title":null,"Paths":null,"Type":"RequestContract"}}</RequestContract>
 		<Name>getPickup(name, mode, group)</Name>
-		<RouteTemplate>getPickup/{name}</RouteTemplate>
+		<RouteTemplate>getPickup</RouteTemplate>
 		<Documentation />
 		<TypeID>7660e907-769c-e711-a182-f079595b3ec7</TypeID>
 		<Service>dcd66369-4933-ed11-1b9c-e3e293f5401c</Service>