Require user IDs for v2 ticket overview

This commit is contained in:
Drechsler, Meik
2026-07-23 18:13:42 +02:00
parent 60e2651641
commit 228dcd6a07
2 changed files with 42 additions and 58 deletions

View File

@@ -247,11 +247,13 @@ namespace C4IT.F4SD
}
[Route("v2/getTicketOverviewCounts"), HttpPost]
public async Task<F4SDHelperService.TicketOverviewCountsResult> getTicketOverviewCountsV2(
public async Task<IHttpActionResult> getTicketOverviewCountsV2(
[FromBody] cTicketOverviewFilterRequest request)
{
if (request?.UserId != Guid.Empty)
return await _f4stHelperService.getTicketOverviewCounts(
if (request == null || request.UserId == Guid.Empty)
return BadRequest("A Matrix42 user ID is required.");
var result = await _f4stHelperService.getTicketOverviewCounts(
request.UserId,
request.Scope,
request.Keys,
@@ -259,13 +261,7 @@ namespace C4IT.F4SD
new List<cApiM42TicketQueueInfo>(),
request.Filters) ?? new F4SDHelperService.TicketOverviewCountsResult();
return await _f4stHelperService.getTicketOverviewCounts(
request?.Sid ?? string.Empty,
request?.Scope ?? "personal",
request?.Keys ?? new List<string>(),
0,
new List<cApiM42TicketQueueInfo>(),
request?.Filters) ?? new F4SDHelperService.TicketOverviewCountsResult();
return Ok(result);
}
[Obsolete("Use getTicketOverviewCountsByRolesForUser with a Matrix42 user ID.")]
@@ -365,11 +361,13 @@ namespace C4IT.F4SD
}
[Route("v2/getTicketOverviewRelations"), HttpPost]
public async Task<List<F4SDHelperService.TicketOverviewRelationDto>> getTicketOverviewRelationsV2(
public async Task<IHttpActionResult> getTicketOverviewRelationsV2(
[FromBody] cTicketOverviewFilterRequest request)
{
if (request?.UserId != Guid.Empty)
return await _f4stHelperService.getTicketOverviewRelations(
if (request == null || request.UserId == Guid.Empty)
return BadRequest("A Matrix42 user ID is required.");
var result = await _f4stHelperService.getTicketOverviewRelations(
request.UserId,
request.Scope,
request.Key,
@@ -378,14 +376,7 @@ namespace C4IT.F4SD
new List<cApiM42TicketQueueInfo>(),
request.Filters) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return await _f4stHelperService.getTicketOverviewRelations(
request?.Sid ?? string.Empty,
request?.Scope ?? "personal",
request?.Key ?? string.Empty,
request?.Count ?? 0,
0,
new List<cApiM42TicketQueueInfo>(),
request?.Filters) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return Ok(result);
}
[Route("v2/getTicketFilterCapabilities"), HttpGet]

View File

@@ -214,25 +214,22 @@ namespace C4IT.F4SD
}
[Route("v2/getTicketOverviewCounts"), HttpPost]
public async Task<F4SDHelperService.TicketOverviewCountsResult> getTicketOverviewCountsV2(
public async Task<IHttpActionResult> getTicketOverviewCountsV2(
[FromBody] cTicketOverviewFilterRequest request)
{
if (request == null || request.UserId == Guid.Empty)
return BadRequest("A Matrix42 user ID is required.");
using (_f4stHelperService.BeginTicketFilterScope(request?.Filters))
{
if (request?.UserId != Guid.Empty)
return await _f4stHelperService.getTicketOverviewCounts(
var result = await _f4stHelperService.getTicketOverviewCounts(
request.UserId,
request.Scope,
request.Keys,
0,
new List<cApiM42TicketQueueInfo>()) ?? new F4SDHelperService.TicketOverviewCountsResult();
return await _f4stHelperService.getTicketOverviewCounts(
request?.Sid ?? string.Empty,
request?.Scope ?? "personal",
request?.Keys ?? new List<string>(),
0,
new List<cApiM42TicketQueueInfo>()) ?? new F4SDHelperService.TicketOverviewCountsResult();
return Ok(result);
}
}
@@ -313,13 +310,15 @@ namespace C4IT.F4SD
}
[Route("v2/getTicketOverviewRelations"), HttpPost]
public async Task<List<F4SDHelperService.TicketOverviewRelationDto>> getTicketOverviewRelationsV2(
public async Task<IHttpActionResult> getTicketOverviewRelationsV2(
[FromBody] cTicketOverviewFilterRequest request)
{
if (request == null || request.UserId == Guid.Empty)
return BadRequest("A Matrix42 user ID is required.");
using (_f4stHelperService.BeginTicketFilterScope(request?.Filters))
{
if (request?.UserId != Guid.Empty)
return await _f4stHelperService.getTicketOverviewRelations(
var result = await _f4stHelperService.getTicketOverviewRelations(
request.UserId,
request.Scope,
request.Key,
@@ -327,13 +326,7 @@ namespace C4IT.F4SD
0,
new List<cApiM42TicketQueueInfo>()) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return await _f4stHelperService.getTicketOverviewRelations(
request?.Sid ?? string.Empty,
request?.Scope ?? "personal",
request?.Key ?? string.Empty,
request?.Count ?? 0,
0,
new List<cApiM42TicketQueueInfo>()) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return Ok(result);
}
}