Require user IDs for v2 ticket overview

This commit is contained in:
Drechsler, Meik
2026-07-23 18:13:42 +02:00
parent 60e2651641
commit 228dcd6a07
2 changed files with 42 additions and 58 deletions

View File

@@ -247,25 +247,21 @@ namespace C4IT.F4SD
} }
[Route("v2/getTicketOverviewCounts"), HttpPost] [Route("v2/getTicketOverviewCounts"), HttpPost]
public async Task<F4SDHelperService.TicketOverviewCountsResult> getTicketOverviewCountsV2( public async Task<IHttpActionResult> getTicketOverviewCountsV2(
[FromBody] cTicketOverviewFilterRequest request) [FromBody] cTicketOverviewFilterRequest request)
{ {
if (request?.UserId != Guid.Empty) if (request == null || request.UserId == Guid.Empty)
return await _f4stHelperService.getTicketOverviewCounts( return BadRequest("A Matrix42 user ID is required.");
request.UserId,
request.Scope,
request.Keys,
0,
new List<cApiM42TicketQueueInfo>(),
request.Filters) ?? new F4SDHelperService.TicketOverviewCountsResult();
return await _f4stHelperService.getTicketOverviewCounts( var result = await _f4stHelperService.getTicketOverviewCounts(
request?.Sid ?? string.Empty, request.UserId,
request?.Scope ?? "personal", request.Scope,
request?.Keys ?? new List<string>(), request.Keys,
0, 0,
new List<cApiM42TicketQueueInfo>(), new List<cApiM42TicketQueueInfo>(),
request?.Filters) ?? new F4SDHelperService.TicketOverviewCountsResult(); request.Filters) ?? new F4SDHelperService.TicketOverviewCountsResult();
return Ok(result);
} }
[Obsolete("Use getTicketOverviewCountsByRolesForUser with a Matrix42 user ID.")] [Obsolete("Use getTicketOverviewCountsByRolesForUser with a Matrix42 user ID.")]
@@ -365,27 +361,22 @@ namespace C4IT.F4SD
} }
[Route("v2/getTicketOverviewRelations"), HttpPost] [Route("v2/getTicketOverviewRelations"), HttpPost]
public async Task<List<F4SDHelperService.TicketOverviewRelationDto>> getTicketOverviewRelationsV2( public async Task<IHttpActionResult> getTicketOverviewRelationsV2(
[FromBody] cTicketOverviewFilterRequest request) [FromBody] cTicketOverviewFilterRequest request)
{ {
if (request?.UserId != Guid.Empty) if (request == null || request.UserId == Guid.Empty)
return await _f4stHelperService.getTicketOverviewRelations( return BadRequest("A Matrix42 user ID is required.");
request.UserId,
request.Scope,
request.Key,
request.Count,
0,
new List<cApiM42TicketQueueInfo>(),
request.Filters) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return await _f4stHelperService.getTicketOverviewRelations( var result = await _f4stHelperService.getTicketOverviewRelations(
request?.Sid ?? string.Empty, request.UserId,
request?.Scope ?? "personal", request.Scope,
request?.Key ?? string.Empty, request.Key,
request?.Count ?? 0, request.Count,
0, 0,
new List<cApiM42TicketQueueInfo>(), new List<cApiM42TicketQueueInfo>(),
request?.Filters) ?? new List<F4SDHelperService.TicketOverviewRelationDto>(); request.Filters) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return Ok(result);
} }
[Route("v2/getTicketFilterCapabilities"), HttpGet] [Route("v2/getTicketFilterCapabilities"), HttpGet]

View File

@@ -214,25 +214,22 @@ namespace C4IT.F4SD
} }
[Route("v2/getTicketOverviewCounts"), HttpPost] [Route("v2/getTicketOverviewCounts"), HttpPost]
public async Task<F4SDHelperService.TicketOverviewCountsResult> getTicketOverviewCountsV2( public async Task<IHttpActionResult> getTicketOverviewCountsV2(
[FromBody] cTicketOverviewFilterRequest request) [FromBody] cTicketOverviewFilterRequest request)
{ {
if (request == null || request.UserId == Guid.Empty)
return BadRequest("A Matrix42 user ID is required.");
using (_f4stHelperService.BeginTicketFilterScope(request?.Filters)) using (_f4stHelperService.BeginTicketFilterScope(request?.Filters))
{ {
if (request?.UserId != Guid.Empty) var result = await _f4stHelperService.getTicketOverviewCounts(
return await _f4stHelperService.getTicketOverviewCounts( request.UserId,
request.UserId, request.Scope,
request.Scope, request.Keys,
request.Keys,
0,
new List<cApiM42TicketQueueInfo>()) ?? new F4SDHelperService.TicketOverviewCountsResult();
return await _f4stHelperService.getTicketOverviewCounts(
request?.Sid ?? string.Empty,
request?.Scope ?? "personal",
request?.Keys ?? new List<string>(),
0, 0,
new List<cApiM42TicketQueueInfo>()) ?? new F4SDHelperService.TicketOverviewCountsResult(); new List<cApiM42TicketQueueInfo>()) ?? new F4SDHelperService.TicketOverviewCountsResult();
return Ok(result);
} }
} }
@@ -313,27 +310,23 @@ namespace C4IT.F4SD
} }
[Route("v2/getTicketOverviewRelations"), HttpPost] [Route("v2/getTicketOverviewRelations"), HttpPost]
public async Task<List<F4SDHelperService.TicketOverviewRelationDto>> getTicketOverviewRelationsV2( public async Task<IHttpActionResult> getTicketOverviewRelationsV2(
[FromBody] cTicketOverviewFilterRequest request) [FromBody] cTicketOverviewFilterRequest request)
{ {
if (request == null || request.UserId == Guid.Empty)
return BadRequest("A Matrix42 user ID is required.");
using (_f4stHelperService.BeginTicketFilterScope(request?.Filters)) using (_f4stHelperService.BeginTicketFilterScope(request?.Filters))
{ {
if (request?.UserId != Guid.Empty) var result = await _f4stHelperService.getTicketOverviewRelations(
return await _f4stHelperService.getTicketOverviewRelations( request.UserId,
request.UserId, request.Scope,
request.Scope, request.Key,
request.Key, request.Count,
request.Count,
0,
new List<cApiM42TicketQueueInfo>()) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return await _f4stHelperService.getTicketOverviewRelations(
request?.Sid ?? string.Empty,
request?.Scope ?? "personal",
request?.Key ?? string.Empty,
request?.Count ?? 0,
0, 0,
new List<cApiM42TicketQueueInfo>()) ?? new List<F4SDHelperService.TicketOverviewRelationDto>(); new List<cApiM42TicketQueueInfo>()) ?? new List<F4SDHelperService.TicketOverviewRelationDto>();
return Ok(result);
} }
} }