From 21e9b85be7dfde629dc35532add76df43784cff8 Mon Sep 17 00:00:00 2001
From: Meik <meik.drechsler@consulting4it.de>
Date: Mon, 20 Jul 2026 09:01:52 +0200
Subject: [PATCH] Enable ticket activity rows by default

---
 .../TicketOverviewUpdateServiceTest.cs           | 16 +++++++++++++---
 .../Services/TicketOverviewUpdateService.cs      |  5 +++--
 .../Basics/UserControls/TicketOverview.xaml      |  4 ++--
 3 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/F4SD.Cockpit.Client.Test/Basics/Sevices/TicketOverview/TicketOverviewUpdateServiceTest.cs b/F4SD.Cockpit.Client.Test/Basics/Sevices/TicketOverview/TicketOverviewUpdateServiceTest.cs
index 8cd1a08..d54850e 100644
--- a/F4SD.Cockpit.Client.Test/Basics/Sevices/TicketOverview/TicketOverviewUpdateServiceTest.cs
+++ b/F4SD.Cockpit.Client.Test/Basics/Sevices/TicketOverview/TicketOverviewUpdateServiceTest.cs
@@ -111,7 +111,7 @@ public class TicketOverviewUpdateServiceTest
     }
 
     [Fact]
-    public async Task FetchAsync_TicketAndServiceRequestsCapability_IsSeparatedFromCounts()
+    public async Task FetchAsync_TicketAndServiceRequestsCapability_UsesEnabledDefaultAndIsSeparatedFromCounts()
     {
         // Arrange
         var communication = new FakeCommunication();
@@ -128,6 +128,7 @@ public class TicketOverviewUpdateServiceTest
         var service = CreateService(communication, out _);
         var availabilityChanges = 0;
         service.TicketAndServiceRequestsAvailabilityChanged += (_, _) => availabilityChanges++;
+        Assert.True(service.TicketAndServiceRequestsEnabled);
 
         // Act
         service.UpdateAvailability(true);
@@ -135,7 +136,7 @@ public class TicketOverviewUpdateServiceTest
 
         // Assert
         Assert.True(service.TicketAndServiceRequestsEnabled);
-        Assert.Equal(1, availabilityChanges);
+        Assert.Equal(0, availabilityChanges);
         Assert.Equal(2, service.CurrentCounts["ServiceRequestsNew"].Personal);
         Assert.Equal(4, service.CurrentCounts["ServiceRequestsNew"].Role);
         Assert.DoesNotContain("TicketAndServiceRequestsEnabled", service.CurrentCounts.Keys);
@@ -146,8 +147,17 @@ public class TicketOverviewUpdateServiceTest
         });
         await service.FetchAsync(TileScope.Personal);
 
+        Assert.True(service.TicketAndServiceRequestsEnabled);
+        Assert.Equal(0, availabilityChanges);
+
+        communication.SetCounts(TileScope.Personal, new Dictionary<string, int>(StringComparer.OrdinalIgnoreCase)
+        {
+            ["TicketAndServiceRequestsEnabled"] = 0
+        });
+        await service.FetchAsync(TileScope.Personal);
+
         Assert.False(service.TicketAndServiceRequestsEnabled);
-        Assert.Equal(2, availabilityChanges);
+        Assert.Equal(1, availabilityChanges);
     }
 
     private static TicketOverviewUpdateService CreateService(FakeCommunication communication, out FakeDispatcher dispatcher)
diff --git a/FasdDesktopUi/Basics/Services/TicketOverviewUpdateService.cs b/FasdDesktopUi/Basics/Services/TicketOverviewUpdateService.cs
index e4113b6..94a5486 100644
--- a/FasdDesktopUi/Basics/Services/TicketOverviewUpdateService.cs
+++ b/FasdDesktopUi/Basics/Services/TicketOverviewUpdateService.cs
@@ -25,6 +25,7 @@ namespace FasdDesktopUi.Basics.Services
         #region Fields
 
         private const string TicketAndServiceRequestsEnabledKey = "TicketAndServiceRequestsEnabled";
+        private const bool TicketAndServiceRequestsEnabledDefault = true;
         private readonly ITicketOverviewCommunicationSource _communicationSource;
         private static readonly string[] OverviewKeys = new[]
         {
@@ -58,7 +59,7 @@ namespace FasdDesktopUi.Basics.Services
         private bool _isDemo;
         private bool _initialized;
         private bool _isEnabled;
-        private bool _ticketAndServiceRequestsEnabled;
+        private bool _ticketAndServiceRequestsEnabled = TicketAndServiceRequestsEnabledDefault;
         private readonly Random _random = new Random();
 #if isDemo
         private readonly List<DemoTicketRecord> _persistedDemoTickets = new List<DemoTicketRecord>();
@@ -343,7 +344,7 @@ namespace FasdDesktopUi.Basics.Services
                     : OverviewKeys;
                 var rawCounts = await communication.GetTicketOverviewCounts(requestedKeys, scope == TileScope.Role).ConfigureAwait(false);
                 var counts = new Dictionary<string, int>(StringComparer.OrdinalIgnoreCase);
-                var ticketAndServiceRequestsEnabled = _isDemo;
+                var ticketAndServiceRequestsEnabled = TicketAndServiceRequestsEnabledDefault;
 
                 if (rawCounts != null)
                 {
diff --git a/FasdDesktopUi/Basics/UserControls/TicketOverview.xaml b/FasdDesktopUi/Basics/UserControls/TicketOverview.xaml
index b59c03c..35c34d8 100644
--- a/FasdDesktopUi/Basics/UserControls/TicketOverview.xaml
+++ b/FasdDesktopUi/Basics/UserControls/TicketOverview.xaml
@@ -121,10 +121,10 @@
                 <RowDefinition Height="Auto" />
                 <RowDefinition Height="Auto" />
                 <RowDefinition x:Name="TicketsRow"
-                               Height="0" />
+                               Height="Auto" />
                 <RowDefinition Height="Auto" />
                 <RowDefinition x:Name="ServiceRequestsRow"
-                               Height="0" />
+                               Height="Auto" />
                 <RowDefinition Height="Auto" />
             </Grid.RowDefinitions>
             <Grid.ColumnDefinitions>